Squiz.WhiteSpace.SuperfluousWhitespace.EmptyLines should look outside of functions

[polybuildr]

Currently, Squiz.WhiteSpace.SuperfluousWhitespace only looks inside functions for EmptyLines, but aren't multiple empty lines a concern even outside of functions?

The MediaWiki codesniffer standard recently had this implemented as a custom sniff (wikimedia/mediawiki-tools-codesniffer@3a6709b), and we were wondering if it could be upstreamed.

[aik099]

This is checked indirectly by other sniffs, that require N lines (defaults to 1) to be between methods in a class.

[jkobus]

+1 on this one. It''s working only in methods.

Right now it can be used as:

<ruleset ...>
<rule ref="Squiz.WhiteSpace.SuperfluousWhitespace.EmptyLines"/>
</ruleset>

You would expect it to work in a context of a class.

MediaWiki sniff linked above works like a charm.

[VincentLanglet]

This is checked indirectly by other sniffs, that require N lines (defaults to 1) to be between methods in a class.

There is missing checks since there is no check between constants or comments for example.

[Luc45]

This is checked indirectly by other sniffs, that require N lines (defaults to 1) to be between methods in a class.

Thanks, do you remember which sniff is it?

[LasseRafn]

Any update here? I'd rather not bug my team about this and not all IDEs handle this automatically.

[ZoranMedojevic]

@LasseRafn @Luc45 This code did trick for me squizwhitespacefunctionspacing.