Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-show-gt enhancement #2

Open
wants to merge 25 commits into
base: matrix6-beta
Choose a base branch
from
Open

data-show-gt enhancement #2

wants to merge 25 commits into from

Conversation

mvaldman
Copy link

@mvaldman mvaldman commented Apr 5, 2023

I've noticed that the behaviour of the data-show-gt example doesn't behave as expected.

The example used this metaData keyword to show a number of items %asset_metadata_amount%, where the amount is a number.

I would expect that if the amount is say 3, then 3 items would then be displayed but due to the CSS only the item with attribute data-show-gt="3" actually gets displayed.

my work-around is to add this css to bct.css, I've also extended it to accomodate up to 15 items.

/* BCT Data Show - Overrides */

.bct-show-1 [data-show-gt~="1"],

.bct-show-2 [data-show-gt~="1"],
.bct-show-2 [data-show-gt~="2"],

.bct-show-3 [data-show-gt~="1"],
.bct-show-3 [data-show-gt~="2"],
.bct-show-3 [data-show-gt~="3"],

.bct-show-4 [data-show-gt~="1"],
.bct-show-4 [data-show-gt~="2"],
.bct-show-4 [data-show-gt~="3"],
.bct-show-4 [data-show-gt~="4"],

.bct-show-5 [data-show-gt~="1"],
.bct-show-5 [data-show-gt~="2"],
.bct-show-5 [data-show-gt~="3"],
.bct-show-5 [data-show-gt~="4"],
.bct-show-5 [data-show-gt~="5"],

.bct-show-6 [data-show-gt~="1"],
.bct-show-6 [data-show-gt~="2"],
.bct-show-6 [data-show-gt~="3"],
.bct-show-6 [data-show-gt~="4"],
.bct-show-6 [data-show-gt~="5"],
.bct-show-6 [data-show-gt~="6"],

.bct-show-7 [data-show-gt~="1"],
.bct-show-7 [data-show-gt~="2"],
.bct-show-7 [data-show-gt~="3"],
.bct-show-7 [data-show-gt~="4"],
.bct-show-7 [data-show-gt~="5"],
.bct-show-7 [data-show-gt~="6"],
.bct-show-7 [data-show-gt~="7"],

.bct-show-8 [data-show-gt~="1"],
.bct-show-8 [data-show-gt~="2"],
.bct-show-8 [data-show-gt~="3"],
.bct-show-8 [data-show-gt~="4"],
.bct-show-8 [data-show-gt~="5"],
.bct-show-8 [data-show-gt~="6"],
.bct-show-8 [data-show-gt~="7"],
.bct-show-8 [data-show-gt~="8"],

.bct-show-9 [data-show-gt~="1"],
.bct-show-9 [data-show-gt~="2"],
.bct-show-9 [data-show-gt~="3"],
.bct-show-9 [data-show-gt~="4"],
.bct-show-9 [data-show-gt~="5"],
.bct-show-9 [data-show-gt~="6"],
.bct-show-9 [data-show-gt~="7"],
.bct-show-9 [data-show-gt~="8"],
.bct-show-9 [data-show-gt~="9"],

.bct-show-10 [data-show-gt~="1"],
.bct-show-10 [data-show-gt~="2"],
.bct-show-10 [data-show-gt~="3"],
.bct-show-10 [data-show-gt~="4"],
.bct-show-10 [data-show-gt~="5"],
.bct-show-10 [data-show-gt~="6"],
.bct-show-10 [data-show-gt~="7"],
.bct-show-10 [data-show-gt~="8"],
.bct-show-10 [data-show-gt~="9"],
.bct-show-10 [data-show-gt~="10"],

.bct-show-11 [data-show-gt~="1"],
.bct-show-11 [data-show-gt~="2"],
.bct-show-11 [data-show-gt~="3"],
.bct-show-11 [data-show-gt~="4"],
.bct-show-11 [data-show-gt~="5"],
.bct-show-11 [data-show-gt~="6"],
.bct-show-11 [data-show-gt~="7"],
.bct-show-11 [data-show-gt~="8"],
.bct-show-11 [data-show-gt~="9"],
.bct-show-11 [data-show-gt~="10"],
.bct-show-11 [data-show-gt~="11"],

.bct-show-12 [data-show-gt~="1"],
.bct-show-12 [data-show-gt~="2"],
.bct-show-12 [data-show-gt~="3"],
.bct-show-12 [data-show-gt~="4"],
.bct-show-12 [data-show-gt~="5"],
.bct-show-12 [data-show-gt~="6"],
.bct-show-12 [data-show-gt~="7"],
.bct-show-12 [data-show-gt~="8"],
.bct-show-12 [data-show-gt~="9"],
.bct-show-12 [data-show-gt~="10"],
.bct-show-12 [data-show-gt~="11"],
.bct-show-12 [data-show-gt~="12"],

.bct-show-13 [data-show-gt~="1"],
.bct-show-13 [data-show-gt~="2"],
.bct-show-13 [data-show-gt~="3"],
.bct-show-13 [data-show-gt~="4"],
.bct-show-13 [data-show-gt~="5"],
.bct-show-13 [data-show-gt~="6"],
.bct-show-13 [data-show-gt~="7"],
.bct-show-13 [data-show-gt~="8"],
.bct-show-13 [data-show-gt~="9"],
.bct-show-13 [data-show-gt~="10"],
.bct-show-13 [data-show-gt~="11"],
.bct-show-13 [data-show-gt~="12"],
.bct-show-13 [data-show-gt~="13"],

.bct-show-14 [data-show-gt~="1"],
.bct-show-14 [data-show-gt~="2"],
.bct-show-14 [data-show-gt~="3"],
.bct-show-14 [data-show-gt~="4"],
.bct-show-14 [data-show-gt~="5"],
.bct-show-14 [data-show-gt~="6"],
.bct-show-14 [data-show-gt~="7"],
.bct-show-14 [data-show-gt~="8"],
.bct-show-14 [data-show-gt~="9"],
.bct-show-14 [data-show-gt~="10"],
.bct-show-14 [data-show-gt~="11"],
.bct-show-14 [data-show-gt~="12"],
.bct-show-14 [data-show-gt~="13"],
.bct-show-14 [data-show-gt~="14"],

.bct-show-15 [data-show-gt~="1"],
.bct-show-15 [data-show-gt~="2"],
.bct-show-15 [data-show-gt~="3"],
.bct-show-15 [data-show-gt~="4"],
.bct-show-15 [data-show-gt~="5"],
.bct-show-15 [data-show-gt~="6"],
.bct-show-15 [data-show-gt~="7"],
.bct-show-15 [data-show-gt~="8"],
.bct-show-15 [data-show-gt~="9"],
.bct-show-15 [data-show-gt~="10"],
.bct-show-15 [data-show-gt~="11"],
.bct-show-15 [data-show-gt~="12"],
.bct-show-15 [data-show-gt~="13"],
.bct-show-15 [data-show-gt~="14"],
.bct-show-15 [data-show-gt~="15"] {
    display: block !important
}

fix: Update bct.scss to allow showing of use default toggle in M6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants