Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistencies with Gtk dialog #31

Closed
JubbeArt opened this issue May 7, 2019 · 1 comment
Closed

Inconsistencies with Gtk dialog #31

JubbeArt opened this issue May 7, 2019 · 1 comment
Labels
linux specific to the linux implementation

Comments

@JubbeArt
Copy link
Contributor

JubbeArt commented May 7, 2019

Noticed some minor inconsistencies with other Gtk applications that also uses dialogs:

  • Cancel button should be on left and not on right
  • Accept button always says "Open" or "Save" instead of just "Ok"
  • Title is "Open File" and "Save File" or "Save As" instead of just "Open" and "Load"
  • The dialog and text when asked to overwrite a file is not standard. Most seems to use dlg.SetDoOverwriteConfirmation(true) which automatically creates that dialog in case of an overwrite

I could open a PR to address these if you want

@sqweek
Copy link
Owner

sqweek commented Jun 9, 2019

Thanks for cleaning this up! I've now merged the PR, apologies for the delay.

I had to resolve some conflicts and apparently my test linux environment still doesn't work with gtk3 for reasons I don't have time to look into, so please let me know if anything doesn't work following this commit.

@sqweek sqweek added the linux specific to the linux implementation label Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linux specific to the linux implementation
Projects
None yet
Development

No branches or pull requests

2 participants