fix: Attributes id injection in first tag.

srackham · Feb 12, 2018 · d990464 · d990464
1 parent f1e3ee4
commit d990464
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/main/kotlin/org/rimumarkup/utils.kt b/src/main/kotlin/org/rimumarkup/utils.kt
@@ -74,7 +74,7 @@ object BlockAttributes {
         }
         if (id.isNotBlank()) {
             id = id.toLowerCase()
-            val has_id = result.contains(Regex("""id=".*?"""", RegexOption.IGNORE_CASE))
+            val has_id = result.contains(Regex("""^<[^<]*id=".*?"""", RegexOption.IGNORE_CASE))
             if (has_id || ids.contains(id)) {
                 Options.errorCallback("""duplicate 'id' attribute: ${id}""")
             } else {

diff --git a/src/test/resources/rimu-tests.json b/src/test/resources/rimu-tests.json
@@ -1778,6 +1778,15 @@
       "reset": true
     }
   },
+  {
+    "description": "html id injection in first tag",
+    "input": ".#foo\n<p></p><p id=\"bar\"></p>",
+    "expectedOutput": "<p id=\"foo\"></p><p id=\"bar\"></p>",
+    "expectedCallback": "",
+    "options": {
+      "reset": true
+    }
+  },
   {
     "description": "html attributes skipped by safeMode=2",
     "input": ".[style=\"color: red;\"]\nError message",