Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throws out of range exception when only 1 resume is provided. #95

Closed
1 of 6 tasks
sanketkhajuria opened this issue Aug 5, 2023 · 5 comments
Closed
1 of 6 tasks

Comments

@sanketkhajuria
Copy link

Issue Title

Throws out of range exception when only 1 resume is provided.

Type

  • Big
  • Feature Request
  • Info
  • Bug
  • Documentation
  • Other (please specify):

Description

Throws out of range exception when only 1 resume is provided. List size is 1 but slider gives numbers 0,1,2 due to current implementation. Hence there is an out of range exception due to these numbers.

Screenshots / Code Snippets (if applicable)

Screenshot 2023-08-05 at 9 27 11 PM

Environment

  • Operating System:
  • Browser (if applicable):
  • Version/Commit ID (if applicable):

Possible Solution (if you have any in mind)

Additional Information

@srbhr
Copy link
Owner

srbhr commented Aug 5, 2023

Hi @sanketkhajuria there is a PR that fixes this exact issue. And I'll get it merged today. Thanks for pointing it out.

@sanketkhajuria
Copy link
Author

Okay. Thanks for informing. I too was trying to create a PR for the same.

@srbhr
Copy link
Owner

srbhr commented Aug 5, 2023

Okay @sanketkhajuria please check this PR: #86
And see if there's anything that you can add on top of it. Also join in the discord for the discussion on the roadmap for this.
🔗: https://dsc.gg/resume-matcher

@srbhr
Copy link
Owner

srbhr commented Aug 9, 2023

@sanketkhajuria can you check now, if the same issue persists? I think this was solved with the merged PR by @Hazannovich

@srbhr
Copy link
Owner

srbhr commented Aug 19, 2023

Fixed by the PR @Hazannovich raised.

@srbhr srbhr closed this as completed Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants