Prepare the project to be deployed #85

dpordomingo · 2018-02-12T09:19:38Z

~~Depends on #36 Single Binnary~~
~~Depends on #91 Remove PR from Drone config~~
~~Depends on #90 Define a persistentVolume for internal database~~
~~Depends on https://github.com/src-d/issues-infrastructure/issues/129 Push an example DB into the code-annotation volume~~
~~Depends on https://github.com/src-d/issues-infrastructure/issues/131 Push the final DB into the code-annotation volume~~

Many different fixes and other additions; see commit messages 🗡️

rporres · 2018-02-12T11:08:05Z

helm-charts/code-annotation/templates/persistent-volume-claim.yaml

+  name: {{ template "fullname" . }}
+spec:
+  accessModes:
+    - ReadWriteMany


not supported by GCE

rporres · 2018-02-12T11:10:23Z

helm-charts/code-annotation/values.yaml

@@ -16,6 +16,7 @@ service:
    externalPort: 8080
    internalPort: 8080
    name: code-annotation
+    internalDatabasePath: /var/code-annotation


This does not belong to the service

rporres

How does the application know that database path is in /var/code-annotation?

dpordomingo · 2018-02-13T14:22:54Z

PR description updated.
@rporres your suggestions were addressed by the separated #90 Define a persistentVolume for internal database

bzz · 2018-02-14T11:44:33Z

Updated PR description as src-d/issues-infrastructure#129 is done.

So, right now what's left before merging this seems to be:

fix the authentication problem (creating the OAuth app under srcd)
Single binary #36 to be merged
- rebase over new master
- sanity check
8d1b6a1 to be removed

Please, feel free to update this comment in case something else is missing, etc.

bzz · 2018-02-14T17:36:17Z

\cc @smacker for review

smacker

impossible to run locally with defaults

smacker · 2018-02-14T17:44:00Z

cli/server/server.go

@@ -16,7 +16,7 @@ type appConfig struct {
 	Host        string `envconfig:"HOST"`
 	Port        int    `envconfig:"PORT" default:"8080"`
 	UIDomain    string `envconfig:"UI_DOMAIN" default:"http://127.0.0.1:8080"`
-	DBConn      string `envconfig:"DB_CONNECTION" default:"sqlite://./internal.db"`
+	DBConn      string `envconfig:"DB_CONNECTION" default:"sqlite:///var/code-annotation/internal.db"`


by default server will fail because /var/code-annotation doesn't exist.
not very user-friendly.

Since we're doing prod first that's the expected location we agreed.
We could maybe change the .env.tpl to be:

DB_CONNECTION=sqlite://internal.db

that's what I mean. It's absolutely okay to have /var/code-annotation path as default, but let's keep it simple for developers. Thanks!

👍 If anybody else wonders, feedback seems to be addressed and default for dev env was changed as requested.

smacker · 2018-02-14T17:45:42Z

Makefile

+
+# ci variables
+TRAVIS_BUILD_DIR ?= $(shell pwd)
+CGO_ENABLED = 1


at some point, it was needed, but I also needed to change a big amount of things to make the project deployable.... and maybe another change made not necessary the CGO.
Removed

smacker · 2018-02-14T17:47:15Z

Makefile

+# Set enviroment variables from .env file
+ENV ?= .env
+$(ENV):
+	touch $(ENV)


I would prefer import .env only if it exists instead of creating new one. But up to you.

Done 🗡️

smacker · 2018-02-14T17:50:09Z

package.json

@@ -15,7 +17,7 @@
    "react-split-pane": "^0.1.74",
    "redux": "^3.7.2",
    "redux-devtools-extension": "^2.13.2",
-    "redux-little-router": "^14.2.3",
+    "redux-little-router": "^15.0.0",


could you describe what was the problem?

While trying to make the project buildable it was needed at some point (it was somehow related to FormidableLabs/redux-little-router#266), but it is not longer needed (idk why), so rollbacked.

smacker

good job! don't forget to squash commit later please.

bzz · 2018-02-15T15:09:51Z

#36 is merged now, rebase is in order.

LGTM after that! 🎉

Default value for UI_DOMAIN will be REACT_APP_SERVER_URL

Add react-app-rewired to prod dependencies Remove yarn install from Travis because it's a lint/test dependency

Added during code review: - Provide a default valur for DB_CONNECTION while developing

dpordomingo · 2018-02-15T18:27:02Z

rebased

dpordomingo force-pushed the deploy branch from 265dff1 to 963ed75 Compare February 12, 2018 09:38

dpordomingo changed the title ~~Deploy~~ [WIP][RFC] Deploy Feb 12, 2018

dpordomingo force-pushed the deploy branch from 5103eb7 to de209e6 Compare February 12, 2018 11:04

rporres reviewed Feb 12, 2018

View reviewed changes

bzz assigned dpordomingo Feb 13, 2018

dpordomingo mentioned this pull request Feb 13, 2018

Prepare first release of code annotation #70

Closed

16 tasks

dpordomingo force-pushed the deploy branch from de209e6 to b4baddc Compare February 13, 2018 14:15

dpordomingo changed the title ~~[WIP][RFC] Deploy~~ Deploy Feb 13, 2018

dpordomingo changed the title ~~Deploy~~ Prepare the project to be deployed Feb 13, 2018

dpordomingo requested review from bzz, rporres and smacker and removed request for rporres February 13, 2018 14:23

dpordomingo force-pushed the deploy branch 3 times, most recently from 93e52ce to 8d1b6a1 Compare February 14, 2018 05:39

dpordomingo mentioned this pull request Feb 14, 2018

Unhandled error in /oauth-callback #98

Closed

dpordomingo force-pushed the deploy branch 2 times, most recently from c1ebb3f to 10bf191 Compare February 14, 2018 17:05

smacker suggested changes Feb 14, 2018

View reviewed changes

smacker approved these changes Feb 15, 2018

View reviewed changes

bzz approved these changes Feb 15, 2018

View reviewed changes

dpordomingo added 2 commits February 15, 2018 18:07

Fix Docker entrypoint Dockerfile

cc3028f

Fix problem with src-d/ci.v1 build defaults

342b069

dpordomingo added 10 commits February 15, 2018 18:10

Fix problem with env var in .drone.yml. Remove quotes from env

2c09ebf

Fix problem with default SERVER_URL and REACT_APP_SERVER_URL.

4884f82

Default value for UI_DOMAIN will be REACT_APP_SERVER_URL

Fix problem with links without href

6ec4ab2

fix add certs to the image in order to call GH http endpoints

8315762

Use go 1.9 and alpine 3.7. It comes with yarn v1

fdb4f03

Enhance CI container install phase

b6ecb5f

Export .env only if it has contents

0c79efb

Remove timestamp from gobindata in assets.go and add *.svg

64d24ef

Make PROD the default mode for 'yarn install'.

0f1a069

Add react-app-rewired to prod dependencies Remove yarn install from Travis because it's a lint/test dependency

Make the default path for internal.db the mounted volume

d48a426

Added during code review: - Provide a default valur for DB_CONNECTION while developing

dpordomingo force-pushed the deploy branch from cfc2f64 to 3008219 Compare February 15, 2018 17:12

Update .PHONY targets. Add missing ones

448d198

dpordomingo force-pushed the deploy branch from 3008219 to 448d198 Compare February 15, 2018 18:12

dpordomingo merged commit 208d503 into src-d:master Feb 16, 2018

dpordomingo deleted the deploy branch February 16, 2018 09:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prepare the project to be deployed #85

Prepare the project to be deployed #85

dpordomingo commented Feb 12, 2018 •

edited

rporres Feb 12, 2018

rporres Feb 12, 2018

rporres left a comment

dpordomingo commented Feb 13, 2018

bzz commented Feb 14, 2018 •

edited

bzz commented Feb 14, 2018

smacker left a comment

smacker Feb 14, 2018

dpordomingo Feb 14, 2018

smacker Feb 14, 2018

bzz Feb 15, 2018

smacker Feb 14, 2018

dpordomingo Feb 15, 2018

smacker Feb 14, 2018

dpordomingo Feb 15, 2018

smacker Feb 14, 2018

dpordomingo Feb 15, 2018 •

edited

smacker left a comment

bzz commented Feb 15, 2018 •

edited

dpordomingo commented Feb 15, 2018

Prepare the project to be deployed #85

Prepare the project to be deployed #85

Conversation

dpordomingo commented Feb 12, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rporres left a comment

Choose a reason for hiding this comment

dpordomingo commented Feb 13, 2018

bzz commented Feb 14, 2018 • edited

bzz commented Feb 14, 2018

smacker left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dpordomingo Feb 15, 2018 • edited

Choose a reason for hiding this comment

smacker left a comment

Choose a reason for hiding this comment

bzz commented Feb 15, 2018 • edited

dpordomingo commented Feb 15, 2018

dpordomingo commented Feb 12, 2018 •

edited

bzz commented Feb 14, 2018 •

edited

dpordomingo Feb 15, 2018 •

edited

bzz commented Feb 15, 2018 •

edited