Add debug logs for job enqueue #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosms
changed the title
carlosms
changed the title
carlosms
changed the title
smacker
reviewed
Jun 12, 2019
issue.go
Outdated
| @@ -47,9 +48,10 @@ func (s *IssueSyncer) QueueRepository(q queue.Queue, owner, repo string) error { | |||
| return err | |||
| } | |||
|
|
|||
| logger.Infof("queue request") | |||
| l := logger.With(log.Fields{"issue": i.GetNumber()}) | |||
| l.Infof("queue request") | |||
There was a problem hiding this comment.
maybe use debug level here?
There was a problem hiding this comment.
I just extended what we had. I'm ok changing everything to debug, and adding LOG_LEVEL=debug to the compose.
Is that preferable?
There was a problem hiding this comment.
I would love to keep starting to publish queue jobs type:reporitory/issues/..., finished to publish queue jobs type:reporitory/issues/... as INFO. So we can see what it is doing. But change queue request to DEBUG so it doesn't spam a lot by default.
There was a problem hiding this comment.
👍 Done. Force-pushed since it's a small change.
smacker
reviewed
Jun 12, 2019
Signed-off-by: Carlos Martín <carlos.martin.sanchez@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some extra logs to see what's going on and detect problems.