Merge pull request #738 from erizocosmico/fix/skip-no-access-dirs

command: skip a directory if gitbase has no permission to read it

cmd/gitbase/command/server.go

@@ -309,6 +309,9 @@ func (c *Server) addMatch(match string) error {
 	initDepth := strings.Count(root, string(os.PathSeparator))
 	return filepath.Walk(root, func(path string, info os.FileInfo, err error) error {
 		if err != nil {
+			if os.IsPermission(err) {
+				return filepath.SkipDir
+			}
 			return err
 		}
 

cmd/gitbase/command/server_test.go

@@ -1,6 +1,7 @@
 package command
 
 import (
+	"os"
 	"testing"
 
 	"github.com/src-d/gitbase"
@@ -10,12 +11,22 @@ import (
 func TestAddMatch(t *testing.T) {
 	require := require.New(t)
 
+	notPermissionDir := "../../../_testdata/not-permission/"
+	fi, err := os.Stat(notPermissionDir)
+	require.NoError(err)
+
+	require.NoError(os.Chmod(notPermissionDir, 0))
+	defer func() {
+		require.NoError(os.Chmod(notPermissionDir, fi.Mode()))
+	}()
+
 	expected := []struct {
 		path string
 		err  func(error, ...interface{})
 	}{
 		{"../../../_testdata/repositories/", require.NoError},
 		{"../../../_testdata/repositories-link/", require.NoError},
+		{notPermissionDir, require.NoError},
 		{"../../../_testdata/repositories-not-exist/", require.Error},
 	}
 	c := &Server{pool: gitbase.NewRepositoryPool(0)}