Close iterators #772
Merged
Close iterators #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kuba-- <kuba@sourced.tech>
dpordomingo
approved these changes
Apr 3, 2019
There was a problem hiding this comment.
I fetched this PR and built to different versions of gitbase: gitbase-master (from master), and gitbase-pr772 (from this PR).
Then I ran the failing query (select count(*) from commits over my 7k repos dataset) some times, against both gitbase versions, and all queries against gitbase-master always failed, and the ones against gitbase-master succeeded.
So I'd say LGTM.
erizocosmico
approved these changes
Apr 3, 2019
ajnavarro
approved these changes
Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kuba-- kuba@sourced.tech
We have a cascade of iterators. Some iterators are not closing (what breaks a chain).
In this PR I tried to close all possible iterators. Rest of the stuff has to be done in mysql. For some cases (where we pass iterator to tables or to builders) I have a feeling that we never have a chance to close it because either it's wrapped by many interfaced or there is no right place where we can do it.
At least those simple
Closestatements can partly fix #765