perf: improve the way we check if refs are not pointing to commits #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #775 Fixes #777 Before, each time we got a new reference, we were checking if it pointed to a commit. This incurred in a performance penalty and an increase of 2x in memory usage and 4x in allocations, as more objects were being read from the repository. Instead, now we use the already present resolveCommit to check it the moment we get the object, since we have to get it anyway. This way, we have the exact same behaviour without having any performance penalty or memory usage increase. Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
kuba--
approved these changes
Apr 5, 2019
ajnavarro
approved these changes
Apr 5, 2019
juanjux
approved these changes
Apr 5, 2019
Good job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #775
Fixes #777
Before, each time we got a new reference, we were checking if it
pointed to a commit. This incurred in a performance penalty and
an increase of 2x in memory usage and 4x in allocations, as more
objects were being read from the repository.
Instead, now we use the already present resolveCommit to check it
the moment we get the object, since we have to get it anyway.
This way, we have the exact same behaviour without having any
performance penalty or memory usage increase.
Signed-off-by: Miguel Molina miguel@erizocosmi.co