Don't skip repos for remotes table with more than 1 URL #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuba--
commented
Apr 9, 2019
remotes_test.go
Outdated
| @@ -151,5 +151,5 @@ func TestRemotesIndexIterClosed(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestRemotesIterClosed(t *testing.T) { | |||
| testTableIterClosed(t, new(remotesTable)) | |||
| testTableIndexIterRows(t, new(remotesTable), 11) | |||
There was a problem hiding this comment.
Actually here I should compare results with non index iterator!
juanjux
approved these changes
Apr 9, 2019
erizocosmico
approved these changes
Apr 9, 2019
Signed-off-by: kuba-- <kuba@sourced.tech>
|
@src-d/data-processing could you review my PR changes, again. I've added some fixes not only for index iterator (but also for |
ajnavarro
reviewed
Apr 10, 2019
remotes.go
Outdated
| @@ -177,13 +174,23 @@ func (i *remotesRowIter) Close() error { | |||
| } | |||
|
|
|||
| func remoteToRow(repoID string, config *config.RemoteConfig, pos int) sql.Row { | |||
| url := "" | |||
There was a problem hiding this comment.
If no URL, it should be nil, right?
There was a problem hiding this comment.
hmm, URLs are strings
There was a problem hiding this comment.
yep, I meant at SQL table level. If there is no value, we should return NULL instead of empty string.
erizocosmico
approved these changes
Apr 10, 2019
Signed-off-by: kuba-- <kuba@sourced.tech>
juanjux
approved these changes
Apr 10, 2019
Signed-off-by: kuba-- <kuba@sourced.tech>
ajnavarro
approved these changes
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kuba-- kuba@sourced.tech
Fixes #788
For remotes with more than 1 URL,
remotesIndexKeyValueIterskip repos.