Feature/commit file stats #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erizocosmico
force-pushed
the
feature/commit-file-stats
branch
2 times, most recently
from
ac7f6a3
to
758ea6a
Compare
|
Rebased |
|
Ready to be merged after the discussion in the issue. |
ajnavarro
reviewed
Jun 17, 2019
erizocosmico
force-pushed
the
feature/commit-file-stats
branch
from
758ea6a
to
fdce3b2
Compare
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
erizocosmico
force-pushed
the
feature/commit-file-stats
branch
from
fdce3b2
to
bc26937
Compare
|
Rebased against master |
kuba--
approved these changes
Jun 17, 2019
ajnavarro
approved these changes
Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #858
Depends on #864, which depends on #863
Fixes a bug in commit_stats. Now it properly ignores vendored files on the Files field.
Extracts most of the common functionality in commit_stats to share it with commit_file_stats.
I updated the documentation explaining the new behavior if any.
I updated CHANGELOG.md file adding the new feature or bug fix.
I updated go-mysql-server using
make upgradecommand if applicable.I added or updated examples if applicable.
I checked that changes on schema are reflected into the documentation, if applicable.