Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let the user define LOG_LEVEL=info using docker #935

Merged
merged 2 commits into from
Jul 29, 2019
Merged

Let the user define LOG_LEVEL=info using docker #935

merged 2 commits into from
Jul 29, 2019

Conversation

dpordomingo
Copy link
Contributor

fix #934

  • docker entrypoint should not force the usage of 'verbose' mode
  • docker entrypoint uses 'debug' log level as default if not defined (for backward compatibility)
  • verbose flag will override any other passed log level, not only 'info'

TODO;

  • I updated the documentation explaining the new behavior if any.
  • I updated CHANGELOG.md file adding the new feature or bug fix.

n/a

  • I added or updated examples if applicable.
  • I checked that changes on schema are reflected into the documentation, if applicable.
  • I updated go-mysql-server using make upgrade command if applicable.

@dpordomingo
Let the user define LOG_LEVEL=info using docker
7de1eb9 
- docker entrypoint should not force the usage of 'verbose' mode
- docker entrypoint uses 'debug' log level as default if not defined
- verbose flag will override any other passed log level, not only 'info'

Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
@dpordomingo dpordomingo mentioned this pull request Jul 19, 2019
Closed
smola
smola reviewed Jul 25, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@dpordomingo
Document CHANGELOG.md
52f548e 
Signed-off-by: David Pordomingo <david.pordomingo.f@gmail.com>
@smola smola requested a review from a team July 29, 2019 08:25
@ajnavarro ajnavarro merged commit 0b9806b into src-d:master Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smola smola smola left review comments

@juanjux juanjux juanjux approved these changes

@erizocosmico erizocosmico erizocosmico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can not use info logging level from docker image
5 participants
@dpordomingo @smola @juanjux @erizocosmico @ajnavarro