This repository has been archived by the owner on Sep 11, 2020. It is now read-only.
git: return better error message when packfile cannot be downloaded #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the error message when the connection was closed while fetching was "object not found" and was misleading. Now when the packfile size is 0 the error "unable to fetch packfile" is returned. Signed-off-by: Javi Fontan <jfontan@gmail.com>
erizocosmico
approved these changes
Nov 30, 2018
ajnavarro
approved these changes
Nov 30, 2018
|
You can test it, giving to it an empty io.Reader, no? |
Signed-off-by: Javi Fontan <jfontan@gmail.com>
|
I've added a small test that check for |
kuba--
approved these changes
Dec 3, 2018
|
Keep in mind that this needs to trigger a minor, not patch version (new error returned from existing function). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the error message when the connection was closed while fetching was "object not found" and was misleading. Now when the packfile size is 0 the error "unable to fetch packfile" is returned.
Does not come with test as I haven't found a way to correctly break the connection while the packfile is being downloaded. Starting
git daemonand killing it after some time is not deterministic enough and can be flaky.Related to src-d/borges#314