This repository has been archived by the owner on Sep 11, 2020. It is now read-only.
storage: reuse deltas from packfiles #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
ajnavarro
suggested changes
Jul 27, 2017
| return nil | ||
| } | ||
|
|
||
| func (dw *deltaSelector) fixAndBreakChainsOne(objectsToPack map[plumbing.Hash]*ObjectToPack, otp *ObjectToPack) error { |
There was a problem hiding this comment.
why One ? what does it means?
There was a problem hiding this comment.
It's one because it processes just one ObjectToPack.
| } | ||
|
|
||
| do, ok := otp.Object.(plumbing.DeltaObject) | ||
| if !ok { |
| } | ||
|
|
||
| base, ok := objectsToPack[do.BaseHash()] | ||
| if !ok { |
| return nil | ||
| } | ||
|
|
||
| if base.Size() <= otp.Size() { |
There was a problem hiding this comment.
3
1,2 and 3 are almost identical pieces of code. Could you find a way to do not duplicate these code? I know that is plumbing code, difficult to improve, but we can try.
| return nil | ||
| } | ||
|
|
||
| isDelta := otp.Object.Type() == plumbing.OFSDeltaObject || |
There was a problem hiding this comment.
This should be a function.
* Improve checks for encode/decode. * Make it easier to extend this test with more storage backends.
Codecov Report
@@ Coverage Diff @@
## master #515 +/- ##
=========================================
- Coverage 78.28% 77.49% -0.8%
=========================================
Files 128 129 +1
Lines 9539 9685 +146
=========================================
+ Hits 7468 7505 +37
- Misses 1264 1368 +104
- Partials 807 812 +5
Continue to review full report at Codecov.
|
* plumbing: add DeltaObject interface for EncodedObjects that are deltas and hold additional information about them, such as the hash of the base object. * plumbing/storer: add DeltaObjectStorer interface for object storers that can return DeltaObject. Note that calls to EncodedObject will never return instances of DeltaObject. That requires explicit calls to DeltaObject. * storage/filesystem: implement DeltaObjectStorer interface. * plumbing/packfile: packfile encoder now supports reusing deltas that are already computed (e.g. from an existing packfile) if the storage implements DeltaObjectStorer. Reusing deltas boosts performance of packfile generation (e.g. on push).
ObjectType.IsDelta is a convenience function to match both offset and reference delta types.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plumbing: add DeltaObject interface for EncodedObjects that
are deltas and hold additional information about them, such
as the hash of the base object.
plumbing/storer: add DeltaObjectStorer interface for object
storers that can return DeltaObject. Note that calls to
EncodedObject will never return instances of DeltaObject.
That requires explicit calls to DeltaObject.
storage/filesystem: implement DeltaObjectStorer interface.
plumbing/packfile: packfile encoder now supports reusing
deltas that are already computed (e.g. from an existing
packfile) if the storage implements DeltaObjectStorer.
Reusing deltas boosts performance of packfile generation
(e.g. on push).