This repository has been archived by the owner on Sep 11, 2020. It is now read-only.
revlist: do not revisit ancestors as long as all branches are visited #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@erizocosmico rebase |
This change is the fixed version of the previous performance improvement that was reverted due to some bogus logic. Now it's fixed and only stops the iteration if and only if all of the branches we've come across have been visited, being a branch a parent commit of a commit we've visited. Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
erizocosmico
force-pushed
the
perf/revlist-norevisit-ancestors-fixed
branch
from
ded2146
to
5bb64f6
Compare
Codecov Report
@@ Coverage Diff @@
## master #588 +/- ##
==========================================
- Coverage 78.3% 77.73% -0.58%
==========================================
Files 130 130
Lines 10123 10135 +12
==========================================
- Hits 7927 7878 -49
- Misses 1346 1419 +73
+ Partials 850 838 -12
Continue to review full report at Codecov.
|
|
Done @mcuadros |
mcuadros
approved these changes
Sep 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is the fixed version of the previous performance improvement that was reverted due to some bogus logic.
Now it's fixed and only stops the iteration if and only if all of the branches we've come across have been visited, being a branch a parent commit of a commit we've visited.