Skip to content
This repository has been archived by the owner on Sep 11, 2020. It is now read-only.

Fix host redirect handling #819

Closed
wants to merge 1 commit into from
Closed

Conversation

DisposaBoy
Copy link

If you try to clone from a url that redirects to another host e.g. example.com/repo -> github.com/org/repo.git, it results in a redirect to example.com/org/repo.git because ModifyEndpointIfRedirect only takes into account the scheme and path.

@DisposaBoy
Copy link
Author

I'm unable to sign the DCO because the sign-off process is weird, so feel free to consider this a bug report and and use the code as you wish.

@smola
Copy link
Collaborator

smola commented Apr 27, 2018

@DisposaBoy You just need to use -s flag on commit (git commit -s). The -s flag will add the standard git sign-off message.

You can also use -s with --amend to modify an existing commit that was not signed-off (git commit -s --amend).

Keep in mind that signing-off implies that you accept the DCO.

@DisposaBoy
Copy link
Author

@smola IMO, the whole process could be simplified to not require contributors to add their email address to commit messages and/or only do it once.
But to be clear, the weird part that I object(ed) to is the bolded part of the following paragraph from your CONTRIBUTING.md

In order to show your agreement with the DCO you should include at the end of commit message, the following line: Signed-off-by: John Doe john.doe@example.com, using your real name.

If you try to clone from a url that redirects to another host
e.g. `example.com/repo` -> `github.com/org/repo.git`,
it results in a redirect to `example.com/org/repo.git`
because ModifyEndpointIfRedirect only takes into account the scheme and path.

Signed-off-by: DisposaBoy <disposaboy@kuroku.io>
@smola
Copy link
Collaborator

smola commented Apr 27, 2018

@DisposaBoy Thanks for the clarification. I understand that contributing under a pseudonym is a very legitimate use case. But so far, we are not able to accept that under our current legal guidelines.

I have moved this to an issue: #820
And opened an issue for ourselves to check if we can accept pseudonymous contributions in the future: src-d/guide#208

However, according to our present policy, I have to close this PR.

@mcuadros mcuadros closed this Apr 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants