This repository has been archived by the owner on Sep 11, 2020. It is now read-only.
storage/filesystem: keep packs open in PackfileIter #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PackfileIter was not taking into account the option KeepDescriptors and was always closing the file. This caused "file already closed" errors when iterating packfiles in with KeepDescriptors active. Signed-off-by: Javi Fontan <jfontan@gmail.com>
ajnavarro
approved these changes
Sep 20, 2018
mcuadros
suggested changes
Sep 20, 2018
storage/filesystem/object.go
Outdated
| pack billy.File | ||
| iter storer.EncodedObjectIter | ||
| seen map[plumbing.Hash]struct{} | ||
| keepPack bool | ||
| } | ||
|
|
||
| // NewPackfileIter returns a new EncodedObjectIter for the provided packfile |
There was a problem hiding this comment.
Please add some documentation about keepPack
Signed-off-by: Javi Fontan <jfontan@gmail.com>
mcuadros
approved these changes
Sep 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PackfileIter was not taking into account the option KeepDescriptors and was always closing the file. This caused "file already closed" errors when iterating packfiles in with KeepDescriptors active.