Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set limit correctly in batcher queries #109

Merged
merged 1 commit into from Feb 27, 2017

Conversation

erizocosmico
Copy link
Contributor

Limit was only being applied per batch, not globally, because of which the batcher retrieved all rows in the database.

Limit was only being applied per batch, not globally, because of
which the batcher retrieved all rows in the database.
@codecov-io
Copy link

codecov-io commented Feb 26, 2017

Codecov Report

Merging #109 into master will increase coverage by 0.04%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage   80.81%   80.86%   +0.04%     
==========================================
  Files          15       15              
  Lines        2685     2691       +6     
==========================================
+ Hits         2170     2176       +6     
  Misses        351      351              
  Partials      164      164
Impacted Files Coverage Δ
batcher.go 78.94% <77.77%> (+1.16%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1479e9e...137d945. Read the comment docs.

@erizocosmico erizocosmico deleted the bugfix/batcher-limit branch February 26, 2017 16:52
@erizocosmico erizocosmico restored the bugfix/batcher-limit branch February 26, 2017 16:52
@erizocosmico erizocosmico reopened this Feb 27, 2017
@erizocosmico erizocosmico merged commit 1d78553 into src-d:master Feb 27, 2017
@erizocosmico erizocosmico deleted the bugfix/batcher-limit branch February 27, 2017 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants