Skip to content
This repository has been archived by the owner on Jan 28, 2021. It is now read-only.

Cannot parse "show create table a.b" #733

Closed
andremarianiello opened this issue May 29, 2019 · 1 comment · Fixed by #737
Closed

Cannot parse "show create table a.b" #733

andremarianiello opened this issue May 29, 2019 · 1 comment · Fixed by #737
Labels
bug Something isn't working

Comments

@andremarianiello
Copy link

andremarianiello commented May 29, 2019

Queries like

select * from `a.b`

parse, but

show create table `a.b`

does not. It fails with

expecting "`" but got "." instead

I think

steps = parseFuncs{
expectQuote,
readIdent(ident),
expectQuote,
}
is to blame because readIdent tries to parse a valid identifier, but since we are in backticks we should be accepting almost anything here instead.

@erizocosmico erizocosmico added the bug Something isn't working label May 30, 2019
@kuba-- kuba-- self-assigned this May 30, 2019
@andremarianiello
Copy link
Author

I have a branch with changes that appear to fix this, so I will make a PR for that, but if you don't like the solution I am totally fine with using someone else's fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
3 participants