Skip to content
This repository has been archived by the owner on Jan 28, 2021. It is now read-only.

No root span created for a query #778

Closed
zwcn opened this issue Jul 1, 2019 · 1 comment · Fixed by #781
Closed

No root span created for a query #778

zwcn opened this issue Jul 1, 2019 · 1 comment · Fixed by #781
Assignees
Labels
bug Something isn't working

Comments

@zwcn
Copy link

zwcn commented Jul 1, 2019

Hi,

When I made a sql query (like select * from sql where id = 1), I got four traces (see screenshot). I expected that there was a single trace that represented the whole execution path for this query, not four separate traces each of which represented a phase of the execution path.

According to the source code https://github.com/src-d/go-mysql-server/blob/master/server/handler.go#L78-L90, a context ctx is created and is passed into Query. There is no root span created in between.

Is there a way to create a root span without changing the source code? Thanks!

@erizocosmico
Copy link
Contributor

There is no way to create a root span without changing the source code, but a root span should definitely be created for this.

@erizocosmico erizocosmico added the bug Something isn't working label Jul 2, 2019
@erizocosmico erizocosmico changed the title How can i create a root span when a query is made? No root span created for a query Jul 2, 2019
@erizocosmico erizocosmico self-assigned this Jul 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants