Add MaxIdentities parameter #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmarkovtsev
requested changes
Aug 13, 2019
|
ok, I change it, but there is a test that fails on one of the golang versions. cannot reproduce locally, so it takes some time to debug... |
vmarkovtsev
requested changes
Aug 15, 2019
Signed-off-by: Konstantin Slavnov <konstantin@sourced.tech>
vmarkovtsev
approved these changes
Aug 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #42
If a connected component has more than
MaxIdentitiesidentities included It cannot be merged with other identities. However, I decided to not use this parameter when we match by external API and email because it is reliable. It is used when matching by name happens.300 is a default value. I set it when I look at logging output. But we should set it to better value when @EgorBu is done with his experiments in #30