Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename SparkAPI to Engine #111

Merged
merged 1 commit into from
Oct 19, 2017
Merged

Conversation

erizocosmico
Copy link
Contributor

Rename SparkAPI to Engine, continuing what was done in #110

Changes in all the snippets in the documentation and README still pending.

@codecov
Copy link

codecov bot commented Oct 16, 2017

Codecov Report

Merging #111 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #111   +/-   ##
=======================================
  Coverage   90.79%   90.79%           
=======================================
  Files          22       22           
  Lines         619      619           
  Branches       53       53           
=======================================
  Hits          562      562           
  Misses         57       57
Impacted Files Coverage Δ
...la/tech/sourced/engine/iterator/BlobIterator.scala 86.44% <ø> (ø)
...cala/tech/sourced/engine/udf/ExtractUASTsUDF.scala 96.15% <ø> (ø)
...ch/sourced/engine/iterator/ReferenceIterator.scala 100% <ø> (ø)
...h/sourced/engine/iterator/RepositoryIterator.scala 100% <ø> (ø)
.../tech/sourced/engine/iterator/CommitIterator.scala 98.46% <ø> (ø)
...main/scala/tech/sourced/engine/DefaultSource.scala 91.66% <ø> (ø)
...scala/tech/sourced/engine/util/GitUrlsParser.scala 87.5% <ø> (ø)
...ala/tech/sourced/engine/udf/ExtractTokensUDF.scala 66.66% <ø> (ø)
...tech/sourced/engine/iterator/CleanupIterator.scala 75% <ø> (ø)
...c/main/scala/tech/sourced/engine/util/Bblfsh.scala 100% <ø> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ccf8cc...0967d11. Read the comment docs.

@erizocosmico erizocosmico force-pushed the rename/as-engine branch 2 times, most recently from 61adae7 to b2a31b6 Compare October 18, 2017 14:32
@erizocosmico
Copy link
Contributor Author

Rebased against master and ready to be merged

Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
@bzz
Copy link
Contributor

bzz commented Oct 18, 2017

Running it locally with instructions from #111

@bzz
Copy link
Contributor

bzz commented Oct 18, 2017

Scala API works like a charm, will try PySpark as well

@bzz
Copy link
Contributor

bzz commented Oct 18, 2017

@erizocosmico make docker-build fails for me on this branch while following https://github.com/mcarmonaa/spark-api/tree/fix/doc-project-name#build-and-run-docker-to-get-a-jupyter-server

The directory '/home/jovyan/.cache/pip/http' or its parent directory is not owned by the current user and the cache has been disabled. Please check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
The directory '/home/jovyan/.cache/pip' or its parent directory is not owned by the current user and caching wheels has been disabled. check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
Obtaining file:///opt/python-engine
    Complete output from command python setup.py egg_info:
    running egg_info
    creating sourced_engine.egg-info
    writing sourced_engine.egg-info/PKG-INFO
    writing dependency_links to sourced_engine.egg-info/dependency_links.txt
    writing requirements to sourced_engine.egg-info/requires.txt
    writing top-level names to sourced_engine.egg-info/top_level.txt
    writing manifest file 'sourced_engine.egg-info/SOURCES.txt'
    /opt/conda/lib/python3.6/site-packages/setuptools/dist.py:350: UserWarning: The version specified ('local') is an invalid version, this may not work as expected with newer versions of setuptools, pip, and PyPI. Please see PEP 440 for more details.
      "details." % self.metadata.version
    error: package directory 'sourced/spark' does not exist

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /opt/python-engine/
The command '/bin/sh -c pip install -e /opt/python-engine/' returned a non-zero code: 1
make: *** [docker-build] Error 1

error: package directory 'sourced/spark' does not exist - is that something wrong on my dev env (do not have any global python packages installed) or could be related to package rename?

Same command on master branch works for me.
Wonder why CI is green - I guess, on tag release it would have failed the same.

@bzz
Copy link
Contributor

bzz commented Oct 18, 2017

Just noticed that history has been re-writted and I was using b2a31b6 instead of now latest 0967d11 :/

Latest version builds like a charm!

@bzz
Copy link
Contributor

bzz commented Oct 18, 2017

Example notebook in docker and ./spark-shell work very well! 🎉

Shall we merge it?

@erizocosmico erizocosmico merged commit dd8de97 into src-d:master Oct 19, 2017
@erizocosmico erizocosmico deleted the rename/as-engine branch October 19, 2017 07:12
@erizocosmico erizocosmico mentioned this pull request Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants