Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landing External Dependents #326

Merged
merged 1 commit into from Nov 15, 2018
Merged

Landing External Dependents #326

merged 1 commit into from Nov 15, 2018

Conversation

ricardobaeta
Copy link
Contributor

Signed-off-by: Ricardo Baeta ricardo@ricardobaeta.com

Copy link
Contributor

@dpordomingo dpordomingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but some missing dependencies at Pardot pages

CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
Copy link
Contributor

@dpordomingo dpordomingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Contributor

@dpordomingo dpordomingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but you need to sign-on the commits :(

CONTRIBUTING.md Outdated Show resolved Hide resolved
Signed-off-by: Ricardo Baeta <ricardo@ricardobaeta.com>

Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
@dpordomingo dpordomingo merged commit add6df8 into master Nov 15, 2018
@dpordomingo dpordomingo deleted the landing-dependencies branch November 20, 2018 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants