Make the announcements section easy to be configured #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
campoy
reviewed
Nov 26, 2018
Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
|
@campoy your suggestion was addressed. But I didn't understood your suggestion about «one reviewing it» |
|
I'm not an expert on frontend tech, so it's probably worth having someone else reviewing the CSS etc. |
|
The CSS and HTML are the.same than the original ones, so if that's your concern, I think we could merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #325
The landing main announcement can be changed modifying
hugo.config.yaml::announcement(here)If no
titleorurlis provided for theannouncement, it wont be shown at the landing (leaving an empty white row in that place)Here is a screenshot with the purpose made by @campoy at #325 (comment)