Skip to content
This repository has been archived by the owner on May 22, 2019. It is now read-only.

Delete hiding sourced-engine usage from algorithms #344

Merged
merged 1 commit into from
Oct 31, 2018
Merged

Delete hiding sourced-engine usage from algorithms #344

merged 1 commit into from
Oct 31, 2018

Conversation

zurk
Copy link
Contributor

@zurk zurk commented Oct 31, 2018

We should make a new release after the merge.

@zurk zurk mentioned this pull request Oct 31, 2018
Merged
vmarkovtsev
vmarkovtsev suggested changes Oct 31, 2018
View reviewed changes
Copy link
Collaborator

@vmarkovtsev vmarkovtsev left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We propose namespaces in src-d/style-analyzer#286 and remove them here :)
Please leave bblfsh_roles and fix it in another way.

@zurk
Delete hiding sourced-engine usage from algorithms
8353ceb 
Signed-off-by: Konstantin Slavnov <kslavnov@gmail.com>
@zurk
Copy link
Contributor Author

zurk commented Oct 31, 2018 •
edited

@vmarkovtsev ready. A lot of imports changed.
But the main idea is

  1. Import from sourced.ml.utils import bblfsh_roles if you need roles, do not import them separately
  2. exclude sourced.ml.utils.engine and sourced.ml.utils.spark from sourced/ml/utils/__init__.py. And if they are required, import them directly.

@vmarkovtsev vmarkovtsev merged commit 0c41c7f into src-d:master Oct 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vmarkovtsev vmarkovtsev vmarkovtsev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zurk @vmarkovtsev