This repository has been archived by the owner on May 22, 2019. It is now read-only.
Fix a missing argument (series) to the call of the save function #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Hula <jan.hula21@gmail.com>
vmarkovtsev
suggested changes
Mar 29, 2019
| @@ -79,7 +79,7 @@ def __call__(self, head: RDD): | |||
| filename = self.get_bow_file_name(self.filename, i) | |||
| BOW() \ | |||
| .construct(docs, tokens, matrix) \ | |||
| .save(filename, deps=(self.df,)) | |||
| .save(filename, series="Bow", deps=(self.df,)) | |||
There was a problem hiding this comment.
You should require "series" argument in __init__, because BowWriter is an implementation of writing the model and it cannot know the specific from the inside.
Signed-off-by: Jan Hula <jan.hula21@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jan Hula jan.hula21@gmail.com