-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename 'install' command as 'init' #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After more thinking a bit more about it I favor up
instead of init
. I also think it should be recommended way to start Source{d} instead of init
and then start
.
The main difference between up
and start
in docker-compose that the first one recreates containers if they were updated. So if an user downloads new docker-compose.yml or makes manual changes up
must be run, not start
or changes in yml won't have any effect.
The name init
sends different message as you have to run it only once for each dataset.
To me both The main advantage I see for So from my side 👍 if @dpordomingo doesn't mind to change the PR. About
I thought this was already the case, current |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm. On another hand for install
(or init
or up
) user have to pass dir to repositories which is annoying. Which means better let user execute this command only once. So then I'm indifferent to init
or up
.
But we definitely need to think a bit more about how to re-create containers.
It is easy with only update
command. But we also have sourced compose download
and sourced compose set
which right now don't work as expected. (At least not as I expect)
I created a new issue so we don't loose this conversation about missing container recreate: #27 |
Since this command can be used to change between working dirs, what is happening in behind is that sandbox is stopped and inited again Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
Given the current state of the discussion, with no strong opinions about using
|
fix #11
After #2, the
install
subcommand is not only used for the first time you run source{d}, but also to come back to a dir that was used previously.As described in #11 I choose
init
, but I'm opened to suggestions.