-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for 'orgs init' #75
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually user can use token without any permissions than only open-source data will be downloaded. It's how I use srcd-ce. Not sure if we should mention it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, maybe we should if we use
src-d,bblfsh
as example. There is no need for any permissions because external users aren't part of src-d or bblfsh orgs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 but even if it's technically possible, I'm not sure we want to document it.
I mean the hassle for the user that needs to create a token it's the same, we are not documenting a more convenient way. If we document private vs public, we may end up causing confusion,. Someone might use a token without access to private repos, and next week complain that the dashboards does not reflect those repos...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking a bit more about this:
This is intended to be friendly to anyone, not just developers. If I log into GitHub with my account, and I see private and public repos in some organizations, and public repos only on others. When I tell
sourced
to download repos from X,Y organization using authentication created from my account, my reference is what I see in GitHub. The less surprising result is to have the same repos, public and private.If we want to provide a way to skip private repos, I think it should not be done tweaking the permissions of the GH token. It could be a setting from the CLI, or a filter in the dashboards.
But if we give here 2 options, and a user chooses permissions for public repos because they will maybe test over
src-d
, when they use the same token 2 weeks from now, they will forget about this detail, and they will not have visibility over whysourced
is not showing private repositories.If we could choose without authentication and with authentication, that would be great. But if we ask to go over the process to create the token, let's just go with one official way to do it, that we know will work as is expected by most people.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to merge, please feel free to open a new issue to continue this discussion if you still think it's better to change it.
It's a minor detail easy to change later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'm okay to discuss it later. I paid attention to it because I'm usually very careful with giving permissions to anything. If it's possible to avoid asking for extra permissions I always would prefer to do it.