Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add quality report on the artificial noisy dataset #366

Merged
merged 4 commits into from Dec 3, 2018
Merged

Add quality report on the artificial noisy dataset #366

merged 4 commits into from Dec 3, 2018

Conversation

warenlg
Copy link
Contributor

@warenlg warenlg commented Dec 3, 2018 •
edited

Signed-off-by: Waren Long waren@sourced.tech
In this PR, I:

  • removed robust-eval and pr-curve commands to make a single one called quality-report-noisy compiling a quality report in a Md format including a precision-recall curve
  • renamed robustness.py to quality_report_noisy.py
  • made use of a jinja2 template to render the quality report in a MD format
  • filled the table with the evaluation metrics

Add quality report on the random noisy dataset
286b551 
Signed-off-by: Waren Long <waren@sourced.tech>
Fix tests for the noisy quality report
95501e8 
Signed-off-by: Waren Long <waren@sourced.tech>
vmarkovtsev
vmarkovtsev requested changes Dec 3, 2018
View reviewed changes
Copy link
Collaborator

@vmarkovtsev vmarkovtsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

lookout/style/format/templates/noisy_quality_report.md.jinja2 Outdated Show resolved Hide resolved
lookout/style/format/templates/noisy_quality_report.md.jinja2 Outdated Show resolved Hide resolved
lookout/style/format/quality_report_noisy.py Outdated Show resolved Hide resolved
lookout/style/format/quality_report_noisy.py Outdated Show resolved Hide resolved
lookout/style/format/quality_report_noisy.py Outdated Show resolved Hide resolved
lookout/style/format/quality_report_noisy.py Outdated Show resolved Hide resolved
lookout/style/format/cmdline_tools.py Outdated Show resolved Hide resolved
Waren Long added 2 commits December 3, 2018 16:15
Fix computational errors among the quality report metrics
e43c0ca 
Signed-off-by: Waren Long <waren@sourced.tech>
Fix Doc and Md template
cf5814b 
Signed-off-by: Waren Long <waren@sourced.tech>
@vmarkovtsev vmarkovtsev merged commit 0b3c9b6 into src-d:master Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmarkovtsev vmarkovtsev vmarkovtsev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@warenlg @vmarkovtsev