added expires after method to cacheable interface

src-run · May 18, 2017 · 41ed413 · 41ed413
1 parent a2dc655
commit 41ed413
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 3 deletions.
diff --git a/lib/AbstractCacheableTransformer.php b/lib/AbstractCacheableTransformer.php
@@ -32,7 +32,19 @@ abstract class AbstractCacheableTransformer extends AbstractTransformer implemen
     public function __construct(CacheItemPoolInterface $cache, \DateInterval $expiresAfter = null)
     {
         $this->cache = $cache;
+        $this->setExpiresAfter($expiresAfter);
+    }
+
+    /**
+     * @param \DateInterval|null $expiresAfter
+     *
+     * @return CacheableTransformerInterface
+     */
+    public function setExpiresAfter(\DateInterval $expiresAfter = null): CacheableTransformerInterface
+    {
         $this->expiresAfter = $expiresAfter;
+
+        return $this;
     }
 
     /**

diff --git a/lib/CacheableTransformerInterface.php b/lib/CacheableTransformerInterface.php
@@ -13,6 +13,13 @@
 
 interface CacheableTransformerInterface extends TransformerInterface
 {
+    /**
+     * @param \DateInterval|null $expiresAfter
+     *
+     * @return self
+     */
+    public function setExpiresAfter(\DateInterval $expiresAfter = null): self;
+
     /**
      * Returns true if the passed string transformation is cached.
      *

diff --git a/tests/AbstractCacheableTransformerTest.php b/tests/AbstractCacheableTransformerTest.php
@@ -170,7 +170,8 @@ private function getLoremText(int $maximumCharacters = null): string
      */
     private function getCacheableSimpleStringTransformerInstance(CacheItemPoolInterface $cache = null, \DateInterval $expiresAfter = null): CacheableTransformerInterface
     {
-        return new StringTransformer($cache ?: $this->getArrayAdapterMock(), $expiresAfter);
+        return (new StringTransformer($cache ?: $this->getArrayAdapterMock()))
+            ->setExpiresAfter($expiresAfter);
     }
 
     /**
@@ -183,8 +184,9 @@ private function getAbstractCacheableTransformerMock(CacheItemPoolInterface $cac
     {
         return $this
             ->getMockBuilder(AbstractCacheableTransformer::class)
-            ->setConstructorArgs([$cache ?: $this->getCacheItemPoolInterfaceMock(), $expiresAfter])
-            ->getMockForAbstractClass();
+            ->setConstructorArgs([$cache ?: $this->getCacheItemPoolInterfaceMock()])
+            ->getMockForAbstractClass()
+            ->setExpiresAfter($expiresAfter);
     }
 
     /**