New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added theme for i3wm #4
Conversation
Hi, thank you for your contribution. I'm having some issues with this theme:
Some opinionated things:
|
Thanks for the feedback roosta. I didn't even know i could define variables in i3 config. Thanks for that. I will do that and see if i can apply your suggestions. |
I'm too lazy to do this the proper way... I have added inn all the colors from the vim version of srcery. I also made some changes to make the active window more focused, and the inactive windows less focused.
|
…clarity between active-unfocused and inactive
@roosta I tried to address your concerns but i might not have the same vision that you do. Let me know what you think. I went a different direction with it. |
@en0 I really like this new revised version, it's still really hard to tell which window has focus if you don't run titlebars like I do. I would recommend setting the active window to something like this:
That gives it gives a bit more contrast to the other windows around the border, and still looks rather neat. |
@en0 I like it, and don't worry about my opinionated comments, that's why I listed those as opinionated :) If I were to nitpick a bit more I think that focused_inactive is not different enough from unfocused, I propose this change:
But its up to you, I'm gonna go ahead and merge this regardless, but there might be some changes down the line if you're ok with that? @R0flcopt3r Thanks for adding your two cents, good too have a few more eyes on this. I no longer have the issue of telling which window is in focus, the blue border solves that handily. Could you share the settings you use that makes it hard to differentiate? |
Thanks to both of you for taking an interest, I hope my nitpicking doesn't kill your enthusiasm. I got my own i3 config as you might have guessed, and some opinions follow, but I'll happily keep those opinions to my own config. |
There are too many configs running about now.. 😂 In the original commit, 0c3962b, the In the latest commit by @en0, be227df, the I think I prefer the colors in be227df, with the modifications from #4 (comment). It's more discrete and I like the added touch of the yellow indicator color, as it matches well with the other color schemes from srcery. I think the bright blue background on the titlebars and statusbar from 0c3962b is a bit distracting. There are still quite a bit of refining and discussion left I think, to make it as polished as the other themes. EDIT:
https://i3wm.org/docs/userguide.html#_changing_colors Footnotes |
Yeah, getting pretty confusing at this point :D Could've sworn that the child border was blue in the latest commit, but seems I'm mistaken. I completely agree that the way it stands now isn't great when trying to differentiate windows. I also still think focused_inactive and focused are too similar. I propose this change then, based on your config example @R0flcopt3r.
I'm also not a huge fan of the orange color used as highlight. I've always thought |
The orange could very well be replaced with yellow, which looks very nice, and obviously matches very well with the yellow indicator. It also indicates which workspace/window you have in focus, which gives it a nice touch, I think. I can't really see a nice place to fit the magenta inn where it's always visible, as it sticks out a lot... However it could work well as |
Yellow is a good compromise, here's my latest attempt:
@R0flcopt3r I had to update your colors, you were using dated white and black colors. They went through a change recently. I haven't properly tested placeholder since I can't find an easy way of spawning one. Might need some work. |
Thanks for the great feedback, I really like the yellow change and I think using magenta on the bar mode indicator makes sense. I will push up changes for that, i am not sure how to get good differentiation between the windows using only boarders without using more color there. there is just not enough contrast between the grays. I will try some of the suggestions from above. |
as you can see from the commit message, that last commit doesn't address the focus visibility when borders are off. I will see if i can come up with something. |
I think this one looks really good except with boarders off, it doesn't feel like a srcery theme. It needs some color. and of-course the boarders are the only opportunity here. |
a note, in gaps, i use smart_gaps and smart_boarders which i think is pretty common. It removes that bright border if you only have one window in the screen. |
@R0flcopt3r I can see where you are coming from. I am going to try to run this for a few days and see if i get any brilliant ideas. or if anyone else has some more tweaks that make it work for everyone. |
I don't mind a bit of color, but its worth noting that various srcery themes lean heavily on the gray colors. Take srcery-tmux for example, or lightline for vim. Granted there are splashes of color there but mainly it's using grays for shading. In my own theme I use magenta as a highlight color, and I don't mind some colorful borders, but I can see where @R0flcopt3r is coming from as well. I could lean either way I guess I'm trying to say. I'll try out some theme variations on my own and if I find anything worthwhile I'll paste it here. |
I suppose there isn't any issue having a |
No, I shouldn't think so, good idea. |
Personally I also like the white/gray colored borders as @R0flcopt3r added. This screenshot is currently using this version. With my setup however, the colors in my status bar is not really matching with the window selector anymore. I was previously using blue as a highlight, which was a better fit with a more colored status bar. Also instead of using magenta I was using yellow for the "mode selector". In conclusion, I like the suggested theme. I will play around with my status bar colors to see if I can get them to fit this theme better. |
i ran the last 2 days at work with the yellow boarder and i have to admit that i really like it. I am willing to change my MR to suite your needs though. If everyone is good with this version i will modify the PR to use it.
|
I don't have time to test this today, but from what I can see it looks good. I'll give it a go tomorrow. Thanks for putting so much effort into this pull request. |
Good changes. I have update the pull request with your changes. Thank you for letting me contribute to your repository. And thank you for the great colors! |
Thank you for the contribution. If everyone is OK with these latest changes (@R0flcopt3r, @barskern ) I'm gonna merge. |
On 29/05/20 00:33, Daniel Berg wrote:
Thank you for the contribution. If everyone is OK ***@***.***) with these latest changes I'm gonna merge.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#4 (comment)
I haven't had time to properly test it yet, but personally the `hard_black` background for inactive windows seems a bit harsh on the eyes. I will give it a testrun later today. However if you all like it, I could also modify it locally if need be.
|
Might be a bit harsh, but it does a good job distinguishing between what is a placeholder and what is just a regular window. I considered just using black but then it just looks like a terminal window. I'm open to other suggestions. Let us know if you find something that works better for you @barskern. |
I'm okay with the changes, and for a merge. |
K, I'm just gonna merge then. Add more comments to this pull request if there's anything that needs tweaking. |
distinguishing between what is a placeholder and what is just a regular window.
Aaah I misunderstood. I didn't notice that you called it placeholders, as I assumed it was "normal" terminal windows. I actually haven't used placeholders before, so TIL! Further hard_black is a good way of making this difference clear.
|
No description provided.