Fix/js vue html issues + feat #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roosta
force-pushed
the
fix/js-vue-html-issues
branch
2 times, most recently
from
5c52e23
to
a9f78c6
Compare
roosta
force-pushed
the
fix/js-vue-html-issues
branch
from
a9f78c6
to
5ec39f4
Compare
roosta
force-pushed
the
fix/js-vue-html-issues
branch
from
5ec39f4
to
ac604c0
Compare
This way javascript in embedded script tags will look fairly normal, some differences cant be accounted for, but close enough. Previously it would render all normal javascript text as special (see html.vim, in my case /usr/share/nvim/runtime/html.vim)
JavaScript being builtin
- identifier - function - operator Fall back to vim defaults for these, brings javascript more in line with other languages. It was also very heavy on the red, so it gets a bit more balanced out
Its the html plugin that defines it, so this is a more correct placement. I considered a rebase, but got to messy, this commit leaves a clean history
roosta
force-pushed
the
fix/js-vue-html-issues
branch
from
ac604c0
to
449abd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix/js vue html issues + feat
I linked the hl group
javaScriptto normal. This makes inline<script>blocks in html much nicer, and fixes javavscript highlighting in vim-vue plugin.I've also sorted and and cleaned up the javascript syntax file
there is one feat commit here, despite the branch name, it clears some syntax hl groups for javascript, so that it'll fall back to what is defined top level (symbol, statement etc(colors/srcery.vim)) This adds some needed variety to js colors, and brings it more inline with other languages.