Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable searching with ISBN #1

Closed
srdg opened this issue Dec 15, 2019 · 3 comments
Closed

Enable searching with ISBN #1

srdg opened this issue Dec 15, 2019 · 3 comments
Assignees
@SuvamPrasd
Labels
easy easy JWoC Contribution good first issue Good for newcomers JWoC Jalpaiguri Winter of Code

Comments

@srdg
Copy link
Owner

srdg commented Dec 15, 2019

In app.py:L17:
Change gc.book(processed_text) to gc.book(isbn=processed_text).
This will make the API search for the book with referenced ISBN number.
@srdg srdg added the good first issue Good for newcomers label Dec 15, 2019
@agarwalBinay18
Copy link

hey,I would like to work on this issue!

@srdg
Copy link
Owner Author

srdg commented Jan 1, 2020

hey,I would like to work on this issue!

Please read the pinned message in the discord channel.

@srdg srdg added JWoC Jalpaiguri Winter of Code easy easy JWoC Contribution labels Jan 1, 2020
@srdg srdg pinned this issue Jan 6, 2020
@srdg srdg unpinned this issue Jan 6, 2020
@srdg srdg mentioned this issue Jan 7, 2020
Open
@SuvamPrasd
Copy link
Contributor

This issue has been fixed and updated.

@srdg srdg closed this as completed Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SuvamPrasd SuvamPrasd

Labels
easy easy JWoC Contribution good first issue Good for newcomers JWoC Jalpaiguri Winter of Code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@srdg @SuvamPrasd @agarwalBinay18