Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript type declaration file #1

Closed
geopic opened this issue Dec 15, 2020 · 2 comments · Fixed by #2
Closed

TypeScript type declaration file #1

geopic opened this issue Dec 15, 2020 · 2 comments · Fixed by #2
Labels
enhancement New feature or request

Comments

@geopic
Copy link
Contributor

geopic commented Dec 15, 2020

If you want I can write a TypeScript type declaration file for this package so that TS developers can utilise the type-checking feature of the language as they use this package. Let me know if you are interested.
@srebughini srebughini added the enhancement New feature or request label Dec 16, 2020
@srebughini
Copy link
Owner

Hey,

thank you for your idea. Sure, I don't know how to do something like this, so your contribution is very welcome 👍

@geopic
Copy link
Contributor Author

geopic commented Dec 21, 2020

Excellent. You don't need to do much, just check if the data types are correct in my PR 😄

@geopic geopic mentioned this issue Dec 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add types declaration file
2 participants
@srebughini @geopic