Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort table results by ascending file size #27

Merged
merged 6 commits into from
Jan 18, 2023

Conversation

beeb
Copy link
Contributor

@beeb beeb commented Jan 18, 2023

This change makes the result table sorted by ascending size, allowing the user to immediately see the largest file at the bottom of the (potentially large) output.

@beeb
Copy link
Contributor Author

beeb commented Jan 18, 2023

As a future improvement, one could maybe sort the results by descending file size in interactive mode

@sreedevk sreedevk changed the base branch from main to development January 18, 2023 07:38
src/output.rs Outdated Show resolved Hide resolved
@beeb
Copy link
Contributor Author

beeb commented Jan 18, 2023

generally do you want me to base my branches on development or main when making these PRs?

@beeb
Copy link
Contributor Author

beeb commented Jan 18, 2023

As a future improvement, one could maybe sort the results by descending file size in interactive mode

I just squeezed in this feature too

@sreedevk
Copy link
Owner

So to make it easier for me to test before merging to main, I added the development branch. The version releases will be whatever the state of the development branch is at that point.

So you can raise all your PRs against development going forward and I'll merge it to main when I'm about to create a release.

@sreedevk sreedevk merged commit f0ff1ec into sreedevk:development Jan 18, 2023
@beeb beeb deleted the sorted_by_size branch January 18, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants