Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to globwalk #37

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Switch to globwalk #37

merged 1 commit into from
Jan 23, 2023

Conversation

beeb
Copy link
Contributor

@beeb beeb commented Jan 23, 2023

Not sure if you'll agree to this change, but I was not able to scan my full home directory with deduplicator, probably because it was trying to keep too many open file descriptors. globwalk seems to handle this much better (the default limits the number of open descriptors to a sane value). With this change I was able to scan my full home dir.

I have not tested it extensively but it seems to work for me, even with the --types argument.

src/output.rs Show resolved Hide resolved
src/params.rs Show resolved Hide resolved
@sreedevk
Copy link
Owner

Hey @beeb ! I've been trying to resolve this issue for a bit, I'm glad that you thought of the same thing too. I was trying to build a custom multi threaded directory walker (I couldn't get jwalk to work), but didn't really work with the progress indicator. I think this is definitely a step in the right path. I will review and merge this.

@sreedevk sreedevk merged commit 087f36a into sreedevk:development Jan 23, 2023
@beeb
Copy link
Contributor Author

beeb commented Jan 23, 2023

As a next step I think it could be good to switch to the Builder and set the BASE_PATH like in the example

@beeb beeb deleted the globwalk branch January 23, 2023 21:10
@sreedevk
Copy link
Owner

@beeb I agree, we can also add options in deduplicator for --max-depth & --follow-links and directly map those options to the builder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants