Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use globwalk builder pattern #41

Merged
merged 1 commit into from
Jan 23, 2023
Merged

refactor: use globwalk builder pattern #41

merged 1 commit into from
Jan 23, 2023

Conversation

beeb
Copy link
Contributor

@beeb beeb commented Jan 23, 2023

I took the chance to remove some back and forth between OsStr, &str and PathBuf and return an iterator from the new get_glob_walker method.

@beeb beeb mentioned this pull request Jan 23, 2023
Closed
@sreedevk
Copy link
Owner

:shipit: this is awesome @beeb Thank you!

@sreedevk sreedevk merged commit de6d2e3 into sreedevk:development Jan 23, 2023
@beeb beeb deleted the globwalk-builder branch February 6, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@beeb @sreedevk