Skip to content
This repository has been archived by the owner on Dec 29, 2023. It is now read-only.

Commit

Permalink
chore: update version
Browse files Browse the repository at this point in the history
  • Loading branch information
srevinsaju committed Nov 10, 2020
1 parent c70fe71 commit 2be6c2a
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion guiscrcpy.desktop
@@ -1,5 +1,5 @@
[Desktop Entry]
Version=v4.7.3
Version=v4.7.2-42-gc70fe71
Name=guiscrcpy
GenericName=guiscrcpy
Comment=Open Source Android Screen Mirroring System
Expand Down
2 changes: 1 addition & 1 deletion guiscrcpy/version.py
Expand Up @@ -20,4 +20,4 @@
"""

VERSION = "v4.7.3"
VERSION = "v4.7.2-42-gc70fe71"
2 changes: 1 addition & 1 deletion setup.py
Expand Up @@ -49,7 +49,7 @@

setup(
name="guiscrcpy",
version="v4.7.3",
version="v4.7.2-42-gc70fe71",
description="An Open Source - Fast - Android Screen Mirroring system.",
long_description=long_description,
long_description_content_type='text/markdown',
Expand Down
2 changes: 1 addition & 1 deletion snap/gui/guiscrcpy.desktop
@@ -1,5 +1,5 @@
[Desktop Entry]
Version=v4.7.3
Version=v4.7.2-42-gc70fe71
Name=guiscrcpy
GenericName=guiscrcpy
Comment=Open Source Android Screen Mirroring System
Expand Down
2 changes: 1 addition & 1 deletion snap/snapcraft.yaml
@@ -1,5 +1,5 @@
name: guiscrcpy
version: v4.7.3
version: v4.7.2-42-gc70fe71
summary: An opensource GUI for android screen mirroring
description: |
A full fledged GUI integration for the award winning open source scrcpy, for
Expand Down

2 comments on commit 2be6c2a

@yochananmarqos
Copy link

@yochananmarqos yochananmarqos commented on 2be6c2a Nov 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've lost track of how many times you've randomly decided to change the versioning. This makes it difficult for me to keep up with a working pkgver() function in my guiscrcpy-git AUR package. You've broken it for now, but no one complained, so I'm not touching it until you fix it or the version is higher than the current AUR package version since I don't want to use an epoch.

This works for now, but it's not ideal using grep and sed together when I guess I should use awk. I'm not good with any of them, really.

printf "$(grep -oP "(?<=version=\"v).*(?=\")" setup.py | sed 's/-/./g')"

Every other VCS package in the AUR with git tags works with this:

git describe --long --tags | sed 's/^v//;s/\([^-]*-g\)/r\1/;s/-/./g'

@srevinsaju
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize. Should be fixed with the upcoming release v4.7.4

Please sign in to comment.