Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent "Folder" setting #4

Closed
Cito opened this issue Feb 18, 2024 · 3 comments
Closed

Inconsistent "Folder" setting #4

Cito opened this issue Feb 18, 2024 · 3 comments

Comments

@Cito
Copy link
Contributor

Cito commented Feb 18, 2024

I noticed that the "Folder" setting works differently for calendar and interval based journals. For calendar based journals, this folder is interpreted as relative to the folder configured in the core daily notes plugin, whereas for interval based journals, it is relative to the root path. Is this difference intended? If yes, it would be helpful to mention it on the settings page.

@srg-kostyrko
Copy link
Owner

Calendar based journals have additional setting Root folder and section(daily, weekly etc.) folders are relative to it. Maybe in your case that root folder is the same as folder configured in the core daily notes plugin and that is why it looks like it took settings from core plugin.

I'll add more details to folder setting description for clarity.

@Cito
Copy link
Contributor Author

Cito commented Feb 19, 2024

Thanks - you're right, that was in fact the case. I overlooked it because the Root folder setting is not part of the same dialog, but in the parent dialog. If you just add some words about this where the Folder setting is shown, this would be sufficient.

@srg-kostyrko
Copy link
Owner

Yeh that will be done in #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants