Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support dot . in file name #369

Closed
bangedorrunt opened this issue Sep 2, 2020 · 2 comments
Closed

support dot . in file name #369

bangedorrunt opened this issue Sep 2, 2020 · 2 comments
Labels
good first issue Good for newcomers

Comments

@bangedorrunt
Copy link

i'd like to have . support in file name, for example learn.me.some.

@srid srid added the good first issue Good for newcomers label Sep 2, 2020
@srid
Copy link
Owner

srid commented Sep 2, 2020

To implement this, modify this function:

customIDParser :: Parser Text
customIDParser = do
fmap toText $ M.some $ M.alphaNumChar <|> M.char '_' <|> M.char '-'

And expand the test coverage.

@srid
Copy link
Owner

srid commented Sep 13, 2020

Dot is possibly going to be used to signify hierarchy in #379

@srid srid closed this as completed in 27e1dea Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants