Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefully handle errors; UI changes #202

Merged
merged 21 commits into from
May 23, 2020
Merged

Gracefully handle errors; UI changes #202

merged 21 commits into from
May 23, 2020

Conversation

srid
Copy link
Owner

@srid srid commented May 23, 2020 •
edited
Loading

Includes srid/reflex-dom-pandoc#2

  • Display errors in the zettel HTML
    • as well as the terminal
  • Graph is built, despite errors (bad queries are not used when finding connections)
  • Refactor a bunch of places
  • Affects the CLI (eg: neuron query

additional changes

  • a bunch of UI changes as well, notably footer is gone, replaced by a top-left sidebar menu (displayed at the bottom on mobile)

todo

@srid srid changed the title Gracefully handle errors Gracefully handle errors; UI changes May 23, 2020
@srid srid marked this pull request as ready for review May 23, 2020 17:37
@srid srid merged commit 6e4a0ad into master May 23, 2020
@srid srid deleted the uniform-render branch May 23, 2020 17:37
srid added a commit that referenced this pull request May 23, 2020
@srid
Include no-such-zettel errors in z-index
50f0eb9 
Overlooked when doing #202
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Be more resilient of user errors CLI should handle errors from Action monad sensibly
1 participant
@srid