-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web search #90
Web search #90
Conversation
Just took a casual look. This is great!
That should be fine, as long as the new dependencies are managed by Nix. As for offline, that's not even supported right now (see |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't looked this in detail yet, but added some comments for now.
A couple of comments regarding the footer:
Here, the search icon should be at the center, with the z-index icon placed in the far right. If |
Also, search doesn't work in the local version ( |
Especially when there are only three of them.
This implements a search page where users can query the zettelkasten by title and by tags.
Filter by dateWill integrate dates into the index laterSorting (alphabetically, chronologically, ...)Useless without the date and more fields to sort byI was planning on using Semantic UI modules for the interface of advanced search, which requires JavaScript content. We therefore must think about whether or not the search page should be accessible locally (or even offline) which would mean adding an npm dependency.