Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added default header and footer. #138

Merged
merged 1 commit into from
Apr 24, 2020

Conversation

arshadkhan53
Copy link
Contributor

No description provided.

Copy link
Contributor

@vaibhavjain-in vaibhavjain-in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arshadkhan53 All this will be part of Demo module.
Reason being - Menu and Block placement is something we are not doing, it is part of front end and not any BE functionality.

@arshadkhan53 arshadkhan53 force-pushed the ez-16-place-header-footer-on-prifile-install branch from 35e29dc to dce4f09 Compare April 23, 2020 15:10
Fixed PR comments.

Removed ezcontent_menu module as per pr comment.
@arshadkhan53 arshadkhan53 force-pushed the ez-16-place-header-footer-on-prifile-install branch from 902d21b to 35dc6b8 Compare April 24, 2020 04:55
@arshadkhan53
Copy link
Contributor Author

PR comments has been addressed.

Copy link
Contributor

@vaibhavjain-in vaibhavjain-in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arshadkhan53 arshadkhan53 merged commit 9e537ab into 8.x Apr 24, 2020
@vaibhavjain-in vaibhavjain-in deleted the ez-16-place-header-footer-on-prifile-install branch June 16, 2020 06:26
riteshgurung pushed a commit that referenced this pull request Jun 17, 2020
…rifile-install

Added default header and footer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants