Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update shell escape code to make it work on all platforms #105

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Update shell escape code to make it work on all platforms #105

merged 1 commit into from
Jul 13, 2020

Conversation

WSMathias
Copy link
Contributor

Fixes: #104
Before:
Screenshot 2020-07-13 at 10 02 12 AM
After:
Screenshot 2020-07-13 at 10 02 25 AM

@AshishThakur
Copy link
Contributor

@vs4vijay can you review?

vs4vijay
vs4vijay approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@vs4vijay vs4vijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine!

@vs4vijay
Copy link
Contributor

However, @WSMathias we need to use printf instead of echo -e next time. printf works in all OSs.

@vs4vijay vs4vijay self-assigned this Jul 13, 2020
@vs4vijay vs4vijay added the bug Something isn't working label Jul 13, 2020
@vs4vijay vs4vijay merged commit e720829 into srijanone:develop Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vs4vijay vs4vijay vs4vijay approved these changes

@AshishThakur AshishThakur Awaiting requested review from AshishThakur

Assignees

@vs4vijay vs4vijay

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Install script printing color code with text
3 participants
@WSMathias @AshishThakur @vs4vijay