Checkin Mailhog in all staarterkits and changed the dependency of chown service. #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharmaamitt16
changed the title
| volumes: *app-volumes | ||
|
|
||
| cli: | ||
| image: "srijanlabs/php-cli:${PHP_VERSION}-10" | ||
| container_name: ${PROJECT_NAME}_cli | ||
| command: ["composer", "install", "--no-dev", "--prefer-dist", "--no-progress", "--no-suggest", "--no-interaction", "--optimize-autoloader"] | ||
| user: continua | ||
| user: root |
There was a problem hiding this comment.
why are we using root user?
There was a problem hiding this comment.
In case there is a specific reason to do this, let's document it and can be fixed later. Adding a comment would be useful.
There was a problem hiding this comment.
I feel no need to document this because while doing composer install with continua user it gives permission error while creating/modifying folders. So I changed this user to root and after cli service, chown service will run and change the ownership of files.
| volumes: *app-volumes | ||
|
|
||
| cli: | ||
| image: "srijanlabs/php-cli:${PHP_VERSION}-10" | ||
| container_name: ${PROJECT_NAME}_cli | ||
| command: ["composer", "install", "--no-dev", "--prefer-dist", "--no-progress", "--no-suggest", "--no-interaction", "--optimize-autoloader"] | ||
| user: continua | ||
| user: root |
There was a problem hiding this comment.
In case there is a specific reason to do this, let's document it and can be fixed later. Adding a comment would be useful.
sharmaamitt16
force-pushed
the
starterkit-optimization
branch
2 times, most recently
from
2ae0016
to
b18a90f
Compare
sharmaamitt16
force-pushed
the
starterkit-optimization
branch
from
b18a90f
to
2c94443
Compare
AshishThakur
approved these changes
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.