vega down & destroy #134
Merged
vega down & destroy #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vs4vijay
reviewed
Aug 10, 2020
There was a problem hiding this comment.
1 suggestion, rest looks okay to me.
Also @WSMathias Please update the README as well as per new changes and commands
cmd/up.go
Outdated
| tilt "github.com/srijanone/vega/pkg/tilt" | ||
| ) | ||
|
|
||
| var watch, noBrowser bool | ||
| var port string | ||
|
|
||
| func isDrupal() bool { |
There was a problem hiding this comment.
Maybe put this method in some Detector package
There was a problem hiding this comment.
sure, I will add Detector package.
AshishThakur
suggested changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New command:
vega destroy
docker-compose down --volumesUpdated command:
vega down
tilt down+docker image rm -f $(docker image ls -q --filter "label=builtby=tilt")vega up
tilt up+docker-compose run --rm cli(only drupal projects)