Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding specific type for checksum-mismatch-exceptions. #74

Merged
merged 3 commits into from Oct 6, 2019
Merged

Conversation

joorei
Copy link
Contributor

@joorei joorei commented Sep 30, 2019

I want to be able to detect and handle ZipExceptions resulting from checksum mismatches with custom logic. Would be glad if this could make it into master.

Allows to identify ZipExceptions resulting from checksum mismatches.
@srikanth-lingala
Copy link
Owner

Thanks for the proposal. I will include it into zip4j. But I want to add a few tests before I merge it into master. I will add them in the next days and merge this PR.

@srikanth-lingala srikanth-lingala self-assigned this Oct 1, 2019
@srikanth-lingala srikanth-lingala added the new-feature New feature or request label Oct 1, 2019
@srikanth-lingala srikanth-lingala added this to To do in Zip4j Oct 1, 2019
@srikanth-lingala srikanth-lingala moved this from To do to In progress in Zip4j Oct 6, 2019
@srikanth-lingala srikanth-lingala merged commit f019f30 into srikanth-lingala:master Oct 6, 2019
@srikanth-lingala srikanth-lingala moved this from In progress to Review in Zip4j Oct 6, 2019
@srikanth-lingala srikanth-lingala moved this from Review to Done in Zip4j Oct 7, 2019
@joorei joorei deleted the patch-3 branch February 6, 2020 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature New feature or request
Projects
Zip4j
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants