Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis 7 support #193

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Redis 7 support #193

wants to merge 9 commits into from

Conversation

Nanciico
Copy link

Support to analyze RDB version 10.

Be able to decode listpack object to hash,zset.
Be able to decode quicklist object to list, stream.

@oranagra
Copy link
Collaborator

oranagra commented Apr 2, 2023

Thank you for filling that void.
Although this project is kinda dead, maybe we should make a release with this to ease the pain on everyone that's missing this.

Before i try to find time to take a deeper look. is there anything you're aware that's still missing for Redis 7.0 support?

p.s. maybe while at it, you can also handle Redis 7.2 support (listpack used for sets as well)

@oranagra
Copy link
Collaborator

oranagra commented Apr 3, 2023

Rethinking my previous statement, considering this project is abandoned, merging PRs and making a new release could make the wrong impression and can cause someone to think it's alive and build new solutions based on it, which would be a shame.

The main reason i wanted to merge this was that AFAIK there's currently a vacuum around that area, and no tools that can handle Redis 7.0 RDB files.
The project of an official RDB parsing library (redis/redis#11122) would still take time to be ready, and i wanted to give people something useful in the meanwhile...

However, i now took another look at redis-rdb-cli, and it seems it closed that gap and is now able to read listpacks and redis 7.0 RDB files. @leonchen83 please correct me if i'm wrong.

some evidence:
https://github.com/leonchen83/redis-rdb-cli/blob/0780f0082cd22766496dded9d7e69fc916d0fdde/src/main/java/com/moilioncircle/redis/rdb/cli/ext/rct/KeyValRdbVisitor.java#L384
https://github.com/leonchen83/redis-rdb-cli/blob/0780f0082cd22766496dded9d7e69fc916d0fdde/src/main/java/com/moilioncircle/redis/rdb/cli/ext/rct/KeyValRdbVisitor.java#L324

@leonchen83
Copy link

leonchen83 commented Apr 4, 2023

@oranagra redis-rdb-cli fully support redis 7 RDB files

@oranagra
Copy link
Collaborator

oranagra commented Apr 4, 2023

@oranagra redis-rdb-cli fully support redis 7 RDB files

thanks @leonchen83 i was really worried that for a long time there was nothing out there capable of processing listpacks and users who upgraded to 7.0 (and can't downgrade) have nothing to work with.

p.s. I suppose you can start doing the additional minor adjustments for Redis 7.2 (sets use listpack, and and streams active-time)

@ChenWei-XiaoYi
Copy link

ChenWei-XiaoYi commented Mar 23, 2024 via email

@smilyFw
Copy link

smilyFw commented Mar 23, 2024 via email

@jayvdb
Copy link

jayvdb commented Mar 23, 2024

I was able to use https://github.com/leonchen83/redis-rdb-cli with redis dump file format 11

@smilyFw
Copy link

smilyFw commented Apr 19, 2024 via email

@ChenWei-XiaoYi
Copy link

ChenWei-XiaoYi commented Apr 19, 2024 via email

@JunhongMao
Copy link

@sripathikrishnan , this PR is beneficial for my current project, please review and approve it as soon as possible. Currently, my project uses this PR as a patch. Merging it will be good for this project. Thanks a lot.

@ChenWei-XiaoYi
Copy link

ChenWei-XiaoYi commented May 31, 2024 via email

@smilyFw
Copy link

smilyFw commented May 31, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants