Fix code quality #58
Merged
Fix code quality #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have been using Redshift for both brightness and temperature, and yet part of our code was still using redshift to change the hue rather than the temperature.
I deeply regret not doing this during development, but to be fair I was in high school
We need to do this in order to format files with async functions since rustfmt defaults to the 2015 edition, which does not allow them. For some reason, rustfmt does not use the edition from Cargo.toml. See [this issue](rust-lang/rust.vim#368).
This tool is AMAZING. Also had to go in and fix a couple manually, but still it saved me a ton of time.
Futures do not run unless awaited, and so `let _ = socket.shutdown()` was not shutting down the socket at all.
Before I was just acquiring and immediately dropping it without keeping it in scope for the critical section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #57